Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertiaclly centered pilcrow #1590

Closed
wants to merge 1 commit into from
Closed

Conversation

jguddas
Copy link
Member

@jguddas jguddas commented Oct 8, 2023

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

Icon use case

Alternative icon designs

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons:
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to two points of precision.

Before Submitting

@jguddas jguddas marked this pull request as draft October 8, 2023 09:44
@github-actions github-actions bot added the 🎨 icon About new icons label Oct 8, 2023
@github-actions
Copy link

github-actions bot commented Oct 8, 2023

Added or changed icons

icons/pilcrow.svg

Preview cohesion icons/m-square.svg
icons/pilcrow.svg
icons/gamepad-2.svg
Preview stroke widths icons/pilcrow.svg
icons/pilcrow.svg
icons/pilcrow.svg
DPI Preview (24px) icons/pilcrow.svg
Icon X-rays icons/pilcrow.svg

@jguddas jguddas marked this pull request as ready for review October 8, 2023 09:45
@jguddas jguddas requested a review from karsa-mistmere October 8, 2023 09:45
@karsa-mistmere
Copy link
Member

I think in this instance it is preferable for the pilcrow symbol to follow the same baseline as other letter icons typically used in a text editor toolbar. (bold, italic, underline, type, strikethrough, ligature etc)

@jguddas jguddas closed this Oct 8, 2023
@jguddas jguddas changed the title Centered pilcrow Vertiaclly centered pilcrow Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants