Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
npm i --engine-strict eslint-config-wikimedia@latest And disable all the warnings for various reasons. I don’t find n/no-unsupported-features/node-builtins useful at all – if the features in question (global fetch, FormData, buffer.File, Response) were declared experimental on the older Node versions we target, but have since been stabilized in a stable release, and already work in the older Node versions, then I think it’s fair to consider them supported there too: I don’t see why they would be broken in newer releases on those older branches. (And CI already checks that they work in the oldest Node we target.) implicit-arrow-linebreak would require either an overlong line or converting the expression into a block, neither of which I like in combineParams(). And prefer-arrow-callback is explained in the disable comment. Also note that in the last two commits I used the npm option with a wrong name – it’s --engine-strict, not --engines-strict. Apparently npm silently ignores unknown options. (AFAICT it didn’t make a difference for those particular commits anyway.)
- Loading branch information