Skip to content

Commit

Permalink
Add FIXME note
Browse files Browse the repository at this point in the history
  • Loading branch information
luc-github committed Jan 19, 2024
1 parent cbf473a commit 14f9011
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions main/core/esp3d_values.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@ bool ESP3DValues::set_string_value(ESP3DValuesIndex index, const char* value,
element->value = value;
esp3d_log("Setting String value %s for %d", value, (int)index);
if (element->callbackFn) {
//FIXME:Instead of immediatly use the callback function
//we should use a queue and call it in the loop to be sure there is no race condition
element->callbackFn(element->index, value, action);
}
return true;
Expand Down

0 comments on commit 14f9011

Please sign in to comment.