Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dub): update dub to C++17 style exception notation #20

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

larkwiot
Copy link
Contributor

Fixes #19 by using more general noexcept(false) instead of pre-C++17 throw(<exception>) style

@mb6ockatf
Copy link

@larkwiot soon going to be a year since this PR was opened...

@larkwiot
Copy link
Contributor Author

larkwiot commented Jan 1, 2024

@larkwiot soon going to be a year since this PR was opened...

Not much I can do about it. I switched to pugixml for the project I need this for if I remember correctly. Edit: Oh wait, this is for lua. Yeah I gave up on Lua entirely due to its dead ecosystem (I submitted several PRs and issues to other Lua packages around the same time) and used Wren instead

algitbot pushed a commit to alpinelinux/aports that referenced this pull request Sep 30, 2024
@Freed-Wu
Copy link

I have to create another rockspec for this fork: https://github.com/Freed-Wu/code-stats.nvim/blob/main/assets/rockspecs/xml-1.1.3-1.rockspec to make other projects depending on it can work.

@gaspard
Copy link
Member

gaspard commented Dec 31, 2024

Hi everyone, I am no longer involved with Lua and did not see this PR. Please ping me to see how we can move this forward.

@gaspard gaspard merged commit 3eb208a into lubyk:master Dec 31, 2024
@Freed-Wu
Copy link

Freed-Wu commented Jan 1, 2025

Hey, @gaspard if you are no longer involved with lua. perhaps you can invite @larkwiot to maintain this projects by add him to collabrators or organization?

@larkwiot
Copy link
Contributor Author

larkwiot commented Jan 1, 2025

Hey, @gaspard if you are no longer involved with lua. perhaps you can invite @larkwiot to maintain this projects by add him to collabrators or organization?

I appreciate your support, but I am not interested in maintaining any projects at the moment--this was kinda a one-off patch PR.

@Freed-Wu
Copy link

Freed-Wu commented Jan 1, 2025

@gaspard Can you release a new version after this PR?

@gaspard
Copy link
Member

gaspard commented Jan 2, 2025

@Freed-Wu Yes, but I need some guidance. I haven't done any Lua code in some time and am not aware of the semver target I should use, what changed, etc. Support seems to end at 5.3 and we are at 5.4.7.

Any hints so I don't mess up ?

And it seems that I should fix dub directly also, no ?

Thanks for any help here :-)

@Freed-Wu
Copy link

Freed-Wu commented Jan 2, 2025

perhaps you can release a scm-1 version to allow user take a try for nightly build.

@Freed-Wu
Copy link

Freed-Wu commented Jan 9, 2025

Yes, many things are broken, such as document websites: http://doc.lubyk.org/xml.html http://doc.lubyk.org/dub.html
Can you add me to the organization? let me see what can I do.

@gaspard
Copy link
Member

gaspard commented Jan 10, 2025

@Freed-Wu, it is done. Send me an email and I will add you to discord so we can work on these issues together :-)

I'll setup DNS for documentation on midasum with tilia and other open source projects.

g.a.bucher at midasum dot com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xml luarocks does not compile C++17 compiler ( i.e. Ubuntu 22.04 LTS gcc)
4 participants