-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dub): update dub to C++17 style exception notation #20
Conversation
@larkwiot soon going to be a year since this PR was opened... |
Not much I can do about it. I switched to pugixml for the project I need this for if I remember correctly. Edit: Oh wait, this is for lua. Yeah I gave up on Lua entirely due to its dead ecosystem (I submitted several PRs and issues to other Lua packages around the same time) and used Wren instead |
patch from: lubyk/xml#20
I have to create another rockspec for this fork: https://github.com/Freed-Wu/code-stats.nvim/blob/main/assets/rockspecs/xml-1.1.3-1.rockspec to make other projects depending on it can work. |
Hi everyone, I am no longer involved with Lua and did not see this PR. Please ping me to see how we can move this forward. |
@gaspard Can you release a new version after this PR? |
@Freed-Wu Yes, but I need some guidance. I haven't done any Lua code in some time and am not aware of the semver target I should use, what changed, etc. Support seems to end at 5.3 and we are at 5.4.7. Any hints so I don't mess up ? And it seems that I should fix dub directly also, no ? Thanks for any help here :-) |
perhaps you can release a scm-1 version to allow user take a try for nightly build. |
Yes, many things are broken, such as document websites: http://doc.lubyk.org/xml.html http://doc.lubyk.org/dub.html |
@Freed-Wu, it is done. Send me an email and I will add you to discord so we can work on these issues together :-) I'll setup DNS for documentation on midasum with tilia and other open source projects. g.a.bucher at midasum dot com |
Fixes #19 by using more general
noexcept(false)
instead of pre-C++17throw(<exception>)
style