Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move keybinding settings to (Lua-based) setting menu #15791

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

y5nw
Copy link
Contributor

@y5nw y5nw commented Feb 15, 2025

#15614 (comment)

Alternative to #15152.

Due to merge conflicts, please merge this after #14964.

  • Goal of the PR
    This PR removes the dedicated settings menu for keybindings and instead adds the keybinding settings to the "Keyboard and mouse" section in the settings menu.
  • How does the PR work?
    This PR introduces a button_key formspec element for capturing key inputs. This element is used in the Lua-based settings menu.
    The aux1_descends, doubletap_jump, and autojump options (which were also included in the keybinding form) can be found in "Controls" -> "General".
  • Does it resolve any reported issue?
    Fixes Cinematic Camera is not in the keybindings menu #15729; fixes Allow using the delete key as a keybinding #9602.
  • Does this relate to a goal in the roadmap?
    2.3 UI Improvements.

To do

This PR is a Work in Progress.

How to test

See #15152.

@y5nw y5nw added Feature ✨ PRs that add or enhance a feature @ Mainmenu @ Client / Controls / Input UI/UX Waiting (on dependency) Waiting on another PR or external circumstances (not for rebases/changes requested) labels Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@ Client / Controls / Input Feature ✨ PRs that add or enhance a feature @ Mainmenu UI/UX Waiting (on dependency) Waiting on another PR or external circumstances (not for rebases/changes requested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cinematic Camera is not in the keybindings menu Allow using the delete key as a keybinding
1 participant