-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[no sq] Fix ECF_D32 support in ogles2 video driver #15396
Conversation
635b6fd
to
8067093
Compare
OES_depth32 only talks about support for render buffers, not textures, so it's not relevant here: https://github.com/KhronosGroup/OpenGL-Registry/blob/main/extensions/OES/OES_depth32.txt This fixes the scene being black with "video_driver = ogles2" and "enable_post_processing = true" on my desktop computer.
grepping for IRR_COMPILE_GLES2_COMMON gives no other results COGLESCoreExtensionHandler is only used through COpenGL3ExtensionHandler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good, no change on my pc
random thing I found on SO:
maybe we should be preferring edit: also here:
|
Luckily I can declare this "out-of-scope for this PR" 😅 |
fixes #15395
OES_depth32 only talks about support for render buffers, not textures, so it's not relevant here: https://github.com/KhronosGroup/OpenGL-Registry/blob/main/extensions/OES/OES_depth32.txt
This fixes the scene being black with "video_driver = ogles2" and "enable_post_processing = true" on my desktop computer.
To do
This PR is a Ready for Review.
How to test
ogles2 on Android: things should work
ogles2 on desktop: things should work