-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NO SQUASH] Non-SDL: Add opengl3 support #15306
[NO SQUASH] Non-SDL: Add opengl3 support #15306
Conversation
4fab40b
to
e1b9295
Compare
c06d9ef
to
51cb072
Compare
Rebase needed. |
6aef219
to
5c787dc
Compare
The rebase was trivial. I am continuing this until SDL is mandatory on all platforms. |
can you turn this into a real check? side note: this only currently works because the the opengl3 driver doesn't (yet) use the core profile, but runs in the compatibility profile. |
5c787dc
to
08304c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't break anything. shadows work on gl3.
video_driver = opengl3
support for the non-SDL Linux and Win32 Irrlicht device.Benefits:
The change
GL_VENDOR
->GL_RENDERER
was done because latter does provide more helpful information about the video card that is being used. Seedebug_log_level = info
+debug.txt
for comparison.glxinfo | grep "OpenGL vendor string"
(vendor name only)glxinfo | grep "OpenGL renderer string"
(more detailed graphics card information)To do
This PR is Ready for Review.
How to test
USE_SDL2=0
andENABLE_OPENGL3=1