-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small setting-related fixes #13755
Small setting-related fixes #13755
Conversation
This will cause the Keyboard and Mouse page to reappear on Android, containing only the mouse sensitivity setting. Whilst eventually Android will have keyboard and mouse support, we do want this option appear on both pages so it's clear that it applies to touch pad as well. Unfortunately, setting name is a primary key in the new settings GUI which means that whilst a setting can appear multiple times, the definition must be the same. So either we could make it so the settings GUI supports multiple setting definitions with the same name, or we should split this setting and add "touchscreen_sensitivity" as well. If we keep with a single setting, a better name would be good |
Adding a separate |
Updated. |
- Hide repeat_place_time on ENABLE_TOUCH builds as you cannot hold the dig button there - Improve the description of safe_dig_and_place to cover ENABLE_TOUCH builds as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR contains some small setting-related fixes:
It corrects the default value of the
fsaa
setting indefaultsettings.cpp
. The default value of that setting was changed by Add antialiasing filters (FXAA, SSAA) #13253, but the change was only applied tosettingtypes.txt
.It hides the
cinematic_camera_smoothing
setting on ENABLE_TOUCH builds, as cinematic mode is not available there.It makes the
mouse_sensitivity
setting visible again on ENABLE_TOUCH builds, as it also affects "finger sensitivity":https://github.com/minetest/minetest/blob/72ef90885d5030bf6f7f9dd60a475339bde9a929/src/gui/touchscreengui.cpp#L830-L831
To do
This PR is a Ready for Review.
How to test
Look at the settings menu.