Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logo not visible on other pages than homepage #37

Closed
nqb opened this issue Feb 28, 2018 · 4 comments
Closed

Logo not visible on other pages than homepage #37

nqb opened this issue Feb 28, 2018 · 4 comments
Assignees
@coudot
Labels
enhancement
Milestone
0.2

Comments

@nqb
Copy link
Contributor

nqb commented Feb 28, 2018

Hello,

When you use menus on WP, you don't see logo which is display on homepage (in the middle).

Is it possible to change its location to see it when you browse through WP menus ?
@coudot
Copy link
Member

coudot commented Feb 28, 2018

Why not, but where?

@nqb
Copy link
Contributor Author

nqb commented Mar 1, 2018

On websites, a common usage is "a clickable logo in the upper left corner of every page on the site" (see Web Design Standards: 10 Best Practices on the Top 50 Websites).

In WP, we already have this behavior with $messages['title']. Maybe we can locate logo next to.

coudot added a commit that referenced this issue Mar 1, 2018
@coudot
Use logo in menu (#37)
0272301
@coudot
Copy link
Member

coudot commented Mar 1, 2018

Now logo is in menu, let me know if this looks good to you

@coudot coudot self-assigned this Mar 1, 2018
@coudot coudot added this to the 0.2 milestone Mar 1, 2018
@nqb
Copy link
Contributor Author

nqb commented Mar 5, 2018

LGTM.

@nqb nqb closed this as completed Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coudot coudot

Labels
enhancement
Projects
None yet
Milestone
0.2
Development

No branches or pull requests
2 participants
@coudot @nqb