DM-46581: Speed up TimeConverter #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change almost halves the time of |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1090 +/- ##
==========================================
- Coverage 89.69% 89.69% -0.01%
==========================================
Files 361 361
Lines 47278 47306 +28
Branches 9716 9720 +4
==========================================
+ Hits 42407 42429 +22
- Misses 3495 3498 +3
- Partials 1376 1379 +3 ☔ View full report in Codecov by Sentry. |
Include the jd1 and jd2 to ensure that we can recreate the time accurately enough from the repr() form.
Constructing the TimeDelta is slow. Calculating the JD components and explicitly adding them to the epoch JD values is much faster than constructing a TimeDelta and adding that to a Time.
This format is only ever use by TimeConverter so we can trust that the values passed are always OK and skip usual checks.
We would like to get microseconds in our ISO output form.
We only use it in a couple of places explicitly but it is used.
timj
commented
Oct 3, 2024
| # For JD times we want to use jd1 and jd2 to maintain precision. | ||
| if isinstance(t, astropy.time.Time): | ||
| if t.format == "jd": | ||
| return f"astropy.time.Time({t.jd1}, {t.jd2}, scale='{t.scale}', format='{t.format}')" |
There was a problem hiding this comment.
This doesn't trigger with the new code because for Timespan we always convert the Time to nsec internally and then convert back to Time on request and so return a format=unix_tai_fast variant for repr. If we ever decide to simply keep the Timespan we were given then this would trigger again.
timj
commented
Oct 3, 2024
andy-slac
reviewed
Oct 3, 2024
We have decided that returning it in tai unix fast format is going to be confusing since these times are visible to people via Timespan. Therefore switch the format to "jd" and accept a small overhead going from 8us to 10us in construction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changesconfigs/old_dimensions