DM-48760: Simplify if underlying exception has no message #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `SlackWebException.from_exception`, the message of the created `SlackWebException` is based on the type name and message of the underlying exception. However, some underlying exceptions, such as timeout errors, may have no message. In that case, drop the trailing colon and space and set the message of `SlackWebException` to only the name of the type of the underlying exception.
Flesh out the change log entry for Sentry integration helpers.
Similar to `SlackWebException`, simplify the message of `SentryWebException` if the underlying exception has no message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
SlackWebException.from_exceptionandSentryWebException.from_exception, the message of the createdSlackWebExceptionis based on the type name and message of the underlying exception. However, some underlying exceptions, such as timeout errors, may have no message. In that case, drop the trailing colon and space and set the message ofSlackWebExceptionandSentryWebExceptionto only the name of the type of the underlying exception.