Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some warning flags to package.yaml #121

Merged
merged 10 commits into from
Sep 28, 2023
Merged

Add some warning flags to package.yaml #121

merged 10 commits into from
Sep 28, 2023

Conversation

lsrcz
Copy link
Owner

@lsrcz lsrcz commented Sep 27, 2023

This pull request adds some warning flags and fixed all the warnings.

The flags added are:

  • -Wextra
  • -Werror
  • -Wcompat
  • -Widentities
  • -Wincomplete-record-updates
  • -Wmissing-export-lists
  • -Wmissing-home-modules
  • -Wmissing-import-lists
  • -Wpartial-fields
  • -Wunused-type-patterns

Tried to add the following flag, but it is blocked by a Cabal bug that is fixed recently (but not in older stackage LTS snapshot versions) (see haskell/cabal#7352).

  • -Wprepositive-qualified-module

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Attention: 40 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/Grisette/Backend/SBV/Data/SMT/Solving.hs 45.08% <ø> (ø)
src/Grisette/Backend/SBV/Data/SMT/SymBiMap.hs 77.77% <ø> (ø)
src/Grisette/Core/Control/Exception.hs 13.33% <ø> (ø)
src/Grisette/Core/Control/Monad/CBMCExcept.hs 0.00% <ø> (ø)
...tte/Core/Control/Monad/Class/MonadParallelUnion.hs 0.00% <ø> (ø)
src/Grisette/Core/Data/Class/BitVector.hs 0.00% <ø> (ø)
src/Grisette/Core/Data/Class/Bool.hs 12.98% <ø> (ø)
src/Grisette/Core/Data/Class/CEGISSolver.hs 41.93% <ø> (ø)
src/Grisette/Core/Data/Class/Error.hs 16.66% <ø> (ø)
src/Grisette/Core/Data/Class/Evaluate.hs 0.00% <ø> (ø)
... and 40 more

📢 Thoughts on this report? Let us know!.

@lsrcz lsrcz changed the title Add -Wextra to package.yaml Add some warning flags to package.yaml Sep 28, 2023
@lsrcz lsrcz merged commit 40e9032 into main Sep 28, 2023
@lsrcz lsrcz deleted the enable-wextra branch September 28, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant