Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby 3.1 and ruby-head to CI #1430

Closed
wants to merge 1 commit into from
Closed

Add Ruby 3.1 and ruby-head to CI #1430

wants to merge 1 commit into from

Conversation

petergoldstein
Copy link

@petergoldstein petergoldstein commented Jan 31, 2022

Description

This PR adds Ruby 3.1 and ruby-head to CI.

As part of that change it fixes a few keyword argument issues in the specs - three specs were failing because the arguments passed to with were being intepreted as keyword arguments. Wrapping them in explicit hashes resolved those failures.

I also observed a pre-existing failure to post to Coveralls (for all Rubies) that I did not address.

Completed Tasks

  • I have read the Contributing Guide.
  • The pull request is complete (implemented / written).
  • Git commits have been cleaned up (squash WIP / revert commits).
  • I wrote tests and ran bundle exec rake locally (if code is attached to PR).

Fix keyword arguments vs hash issues in specs
@lsegal
Copy link
Owner

lsegal commented Jun 1, 2022

This was resolved by #1424 and #1433, but thank you for the contribution!

Note that ruby-head will not be added since we historically had gottten a lot of regression based failures that I do not have enough bandwidth to work around.

@lsegal lsegal closed this Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants