Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add structural and behavior test files from Artemis #62

Merged
merged 97 commits into from
Nov 17, 2020
Merged

Add structural and behavior test files from Artemis #62

merged 97 commits into from
Nov 17, 2020

Conversation

krusche
Copy link
Member

@krusche krusche commented Nov 11, 2020 •
edited
Loading

This PR adds the files of the default Java programming exercise template.
Currently we copy lots of files into many different repositories that does not need to be change at all.
Putting those into a library such as artemis-java-test-sandbox makes much more sense, therefore I added this PR.
I will create a corresponding PR in Artemis which updates the Java programming exercise template based on these changes.

  • Deploy the snapshot version to Maven so that we can test it in an actual Artemis exercise
  • Release a new official version of artemis-java-test-sandbox (e.g. 1.3.4) and use this in the Artemis template

Related Artemis PR ls1intum/Artemis#2382

@krusche krusche requested a review from MaisiKoleni November 11, 2020 15:54
@krusche krusche mentioned this pull request Nov 11, 2020
Merged
1 task
@MaisiKoleni MaisiKoleni added the enhancement New feature or request label Nov 11, 2020
kloessst
kloessst suggested changes Nov 11, 2020
View reviewed changes
Copy link
Contributor

@kloessst kloessst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this locally with the corresponding Artemis PR. Java template works as expected but Kotlin has problems with class scanning.

src/main/java/de/tum/in/test/api/structural/testutils/ClassNameScanner.java Outdated Show resolved Hide resolved
src/main/java/de/tum/in/test/api/structural/testutils/ClassNameScanner.java Outdated Show resolved Hide resolved
@kloessst kloessst self-requested a review November 12, 2020 02:56
@MaisiKoleni MaisiKoleni self-requested a review November 17, 2020 17:03
MaisiKoleni
MaisiKoleni approved these changes Nov 17, 2020
View reviewed changes
Copy link
Collaborator

@MaisiKoleni MaisiKoleni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@MaisiKoleni MaisiKoleni modified the milestones: Version 1.3.5, Version 1.4.0 Nov 17, 2020
kloessst
kloessst approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@kloessst kloessst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed through the code looks fine!

@MaisiKoleni MaisiKoleni merged commit 3675b57 into master Nov 17, 2020
@MaisiKoleni MaisiKoleni deleted the feature/structural-behavior-artemis branch November 17, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kloessst kloessst kloessst approved these changes

@MaisiKoleni MaisiKoleni MaisiKoleni approved these changes

Assignees

@krusche krusche

@MaisiKoleni MaisiKoleni

@kloessst kloessst

Labels
enhancement New feature or request
Projects
None yet
Milestone
Version 1.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@krusche @MaisiKoleni @kloessst