Revert "fix builder grow"

This reverts commit 80b1beb.
lqs · Jan 6, 2025 · e7c7a9f · e7c7a9f
1 parent 80b1beb
commit e7c7a9f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/common.go b/common.go
@@ -95,9 +95,7 @@ func commaTables(scope scope, tables []Table) string {
 }
 
 func commaValuesBuilder(scope scope, builder *strings.Builder, values []interface{}) error {
-	if len(values) == 0 {
-		return nil
-	}
+	builder.Grow(16 * (len(values) + 2)) // hopefully reduce copying
 	for i, item := range values {
 		if i > 0 {
 			builder.WriteString(", ")

diff --git a/insert.go b/insert.go
@@ -158,11 +158,11 @@ func (s insertStatus) GetSQL() (string, error) {
 				if i > 0 {
 					valuesBuilder.WriteString(", ")
 				}
-				valuesBuilder.WriteByte('(')
+				valuesBuilder.WriteString("(")
 				if err := commaValuesBuilder(s.scope, &valuesBuilder, model.GetValues()); err != nil {
 					return "", err
 				}
-				valuesBuilder.WriteByte(')')
+				valuesBuilder.WriteString(")")
 			}
 		}
 	} else {