Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark ergonomics #126

Merged
merged 5 commits into from
Dec 4, 2024
Merged

Benchmark ergonomics #126

merged 5 commits into from
Dec 4, 2024

Conversation

daun
Copy link
Contributor

@daun daun commented Dec 3, 2024

A few tweaks to the bin/benchmark scripts.

  • Shortened script names (less typing 🥳)
  • Increase memory limit (couldn't get it to run otherwise)
  • Clear index before indexing using new method
  • Add command line options for
    • Limiting the amount of movies to index --limit=1000
    • Re-inserting all existing documents to test update performance: --update
    • Changing the search query term --query="lorem ipsum"
    • Debugging the search results --debug
  • Display search runtime in ms instead of s
  • Reordered time vs. memory (I figured time's more relevant most of the time)
  • Add newline at the end to avoid php adding a % after each run
Screenshot 2024-12-03 at 12 07 13

daun added 5 commits December 3, 2024 12:01
Signed-off-by: Philipp Daun <post@philippdaun.net>
Signed-off-by: Philipp Daun <post@philippdaun.net>
Signed-off-by: Philipp Daun <post@philippdaun.net>
Signed-off-by: Philipp Daun <post@philippdaun.net>
Signed-off-by: Philipp Daun <post@philippdaun.net>
@Toflar Toflar merged commit 5814af3 into loupe-php:develop Dec 4, 2024
18 checks passed
@Toflar
Copy link
Contributor

Toflar commented Dec 4, 2024

Thanks, Philipp!

@daun daun deleted the feat/benchmarks branch December 4, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants