This repository has been archived by the owner on Dec 7, 2020. It is now read-only.
Adding Custom Header from claims #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Apr 16, 2020
|
Questions:
What will be in the X-Auth-Email header in this case: email or give_name or duplicated headers with the same name and different values? |
|
pipe seem to be safe divider so far from my research, claims are usually scoped with : or - , not with pipe. I have updated the docs and made a pull request in doc repository : keycloak/keycloak-documentation#918 Currently as it is using map , it will be over written by which ever is defined later part. |
golangcibot
reviewed
Apr 17, 2020
|
also relates to this issue: https://issues.redhat.com/projects/KEYCLOAK/issues/KEYCLOAK-12343 ... would really appreciate seeing this merged. |
|
Any updates on this ? |
abstractj
approved these changes
Jun 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to add complete custom header parameter to upstream from claims. Currently claims header parameter is prefixied with "X-Auth", which may not be suitable in many cases. Also asked a question in issues: #531