Add block letters for street names #111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add functionality to generate and display block letters for street names. * **src/element_processing/highways.rs** - Add a new function `generate_block_letters` to generate block letters for street names. - Update `generate_highways` function to call `generate_block_letters` when generating street names. * **gui-src/js/main.js** - Add a new function `displayBlockLetters` to handle the display of block letters for street names on the map. - Update `registerMessageEvent` function to call `displayBlockLetters` when receiving block letter data.
| @@ -297,3 +302,252 @@ pub fn generate_siding(editor: &mut WorldEditor, element: &ProcessedWay, ground_ | |||
| previous_node = Some((x, z)); | |||
| } | |||
| } | |||
|
|
|||
| /// Generates block letters for street names | |||
| fn generate_block_letters( | |||
There was a problem hiding this comment.
Could this be done with a lookup-table or something? What about street names that don't use the English alphabet? We may need a more efficient solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add functionality to generate and display block letters for street names.
src/element_processing/highways.rs
generate_block_lettersto generate block letters for street names.generate_highwaysfunction to callgenerate_block_letterswhen generating street names.gui-src/js/main.js
displayBlockLettersto handle the display of block letters for street names on the map.registerMessageEventfunction to calldisplayBlockLetterswhen receiving block letter data.