Fix ssl_client_cert and ssl_client_key #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iMacTia
approved these changes
Jul 6, 2023
There was a problem hiding this comment.
Well, that was an embarrassing miss 😅
Thank you for fixing it @karissekjw and adding tests 💯 🙌
|
@iMacTia thanks for the swift response ⚡ seems like CI failed due to rubocop. Should I open another PR to fix this? |
|
I meant to fix it myself (also because it's unrelated to your changes), but I've been in back-to-back meetings all day. |
karissekjw
added a commit
to karissekjw/faraday-http
that referenced
this pull request
Jul 6, 2023
|
Opened a PR here! #34 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
There is a bug when adding
client_certandclient_keyinto the SSL options where an error is raised due to undefined method.What this PR does
is_a?) to prevent the error from being raised.is_a?only accepts a single argument, this has been fixed too.