Support faraday 2.0 & streaming api

[aka-nez]

Hi! I tried to update the gem to make it compatible with Faraday 2 and add streaming API support.

Take a look. please @iMacTia

Probably, I should update the CI matrix, too: remove 2.5, add 3.0+

[iMacTia]

Thank you @aka-nez 🙌!

Agree about the CI matrix, please make it cover 2.6 -> 3.1 like we do in Faraday.

Out of curiosity, could you explain why you needed to explicitly add the faraday/multipart middleware? What kind of errors were you seeing otherwise?

[aka-nez]

Out of curiosity, could you explain why you needed to explicitly add the faraday/multipart middleware? What kind of errors were you seeing otherwise?

spec/faraday/http/adapter_spec.rb:26 uses this middleware, that was bundled with Faraday before

I tried removing this middleware - all specs passed. I will remove this lines with next commit

[iMacTia]

Thanks for clarifying!
I saw you added it to the Gemfile and spec_helper, so there should be no impact on users of this gem 👍

[aka-nez]

I have updated the CI matrix and entirely removed everything related to multipart. It doesn't impact tests

[olleolleolle]

(I did some cleaning out of earlier Required Build Checks, which included now-removed ones.)

[olleolleolle]

Ah, I noted this in the failure in CI:

Gems in the groups 'development' and 'test' were not installed.

Perhaps some --deployment flag is enabled>

Edit:

BUNDLE_WITHOUT: "development:test"

We can probably drop this, since the bundler-cache make it quick anyway.

[aka-nez]

Removed this line from ci

[olleolleolle]

@iMacTia Are we ready to go, here?

[iMacTia]

Actually, faraday ~> 2.0 is incorrect, we should pin to faraday ~> 2.5 as older versions don't have the new streaming API. Tests are passing because bundler installs the latest version, which works fine.

[aka-nez]

Actually, faraday ~> 2.0 is incorrect, we should pin to faraday ~> 2.5 as older versions don't have the new streaming API. Tests are passing because bundler installs the latest version, which works fine.

Sure. Fixed! 👍

[iMacTia]

Thank you so much @aka-nez, I'm gonna drop a release soon 🙌 !