Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RuboCop to v0.91.1 and use RuboCop::Packaging #27

Merged
merged 3 commits into from
Sep 24, 2020
Merged

Update RuboCop to v0.91.1 and use RuboCop::Packaging #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2abd2fb
Update RuboCop to v0.91.1
utkarsh2102 Sep 23, 2020
1d5e6da
Increase max value of PerceivedComplexity & AbcSize
utkarsh2102 Sep 23, 2020
1d012f3
Add rubocop-packaging & fix its offenses
utkarsh2102 Sep 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
require:
- rubocop-packaging

AllCops:
DisplayCopNames: true
DisplayStyleGuide: true
Expand All @@ -22,7 +25,7 @@ Layout/LineLength:
Max: 100

Metrics/AbcSize:
Max: 25
Max: 28

Metrics/BlockLength:
Exclude:
Expand All @@ -33,7 +36,7 @@ Metrics/CyclomaticComplexity:
Max: 30

Metrics/PerceivedComplexity:
Max: 10
Max: 11

Layout/SpaceAroundMethodCallOperator:
Enabled: true
Expand Down
3 changes: 2 additions & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ gemspec
gem 'multipart-parser'

group :lint, :development do
gem 'rubocop', '~> 0.82.0'
gem 'rubocop', '~> 0.91.1'
gem 'rubocop-packaging', '~> 0.5'
gem 'rubocop-performance', '~> 1.0'
end
1 change: 0 additions & 1 deletion spec/spec_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
minimum_coverage_by_file 75
end

require 'bundler/setup'
require 'faraday/http'
require 'faraday_specs_setup'

Expand Down