Respect connection timeout options #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we don't reassign `conn` to the result of `request_config` the timeout config values are not respected.
olleolleolle
approved these changes
Jun 22, 2020
There was a problem hiding this comment.
Looks right - the explicit return value of #request_config is otherwise a bit unexplainable.
@iMacTia what do you think?
iMacTia
approved these changes
Jun 30, 2020
There was a problem hiding this comment.
I just did a quick research as I found strange that conn.timeout would return a new object (and thus needed re-assigning), but looking into the HTTP gem it seems exactly like that: https://github.com/httprb/http/blob/7ce201ebced7a8e23b7ac39aa85c940739b4c3f3/lib/http/chainable.rb#L253
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't reassign
connto the result ofrequest_configthe timeout config values are not respected.This can be reproduced pretty easily. Create a request to something like https://httpstat.us/200?sleep=5000 with a
timeoutset to 1 second using the:net_httpadapter and it raises aFaraday::TimeoutError. Change the adapter to:httpand no error is raised.This pull request fixes that behavior.