-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Refactor Reduce
operation.
#259
refactor: Refactor Reduce
operation.
#259
Conversation
2d82896
to
3161d23
Compare
d32bf74
to
934f599
Compare
I think I'm done with this PR, let's leave it open a little bit to carefully check if this is the proper thing to do. I know the pace is a bit different during holidays, so, it might take a little while before it gets merged. |
0873de0
to
c785876
Compare
6535897
to
6c7e485
Compare
- compare - min - max
Thanks! I added the remaining operations and updated a couple bits of documentation that were still mentioning I'll give this another fresh look tomorrow, see if I can spot anything else needed. |
Indeed, nice. I was planning to do it after all the commits were done, but you did it. Thanks :)
Ok will do that ! Cheers! |
BREAKING CHANGE: yes
BREAKING CHANGE: yes
BREAKING CHANGE: yes
BREAKING CHANGE: yes
BREAKING CHANGE: yes
BREAKING CHANGE: yes
BREAKING CHANGE: yes
- compare - min - max
3a086f5
to
4013d45
Compare
…://github.com/loophp/collection into 256-reduction-operations-return-singlee-value
@drupol I went through this again and added a few more things. Please feel free to comb through the docs yourself as well and see if you can spot any bits we might have missed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this! 💯
This is super great !!! I propose to merge this, then do remaining changes if any in another branch. We've been waiting for too long for this :) |
BREAKING CHANGE: yes
This PR:
DONE 🟢