Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Refactor Reduce operation. #259

Merged
merged 37 commits into from
Sep 12, 2022

Conversation

drupol
Copy link
Collaborator

@drupol drupol commented Jul 10, 2022

BREAKING CHANGE: yes

This PR:

DONE 🟢

  • first
  • foldLeft
  • foldLeft1
  • foldRight
  • foldRight1
  • implode
  • reduce
  • unlines
  • unwords
  • last
  • head
  • get
  • compare
  • min
  • max

@drupol drupol force-pushed the 256-reduction-operations-return-singlee-value branch 2 times, most recently from 2d82896 to 3161d23 Compare July 11, 2022 15:39
@github-actions github-actions bot added the stale label Jul 17, 2022
@drupol drupol removed the stale label Jul 18, 2022
@github-actions github-actions bot added the stale label Jul 24, 2022
@github-actions github-actions bot closed this Jul 29, 2022
@drupol drupol reopened this Jul 29, 2022
@github-actions github-actions bot removed the stale label Jul 30, 2022
@drupol drupol force-pushed the 256-reduction-operations-return-singlee-value branch 2 times, most recently from d32bf74 to 934f599 Compare August 2, 2022 20:07
@drupol
Copy link
Collaborator Author

drupol commented Aug 2, 2022

I think I'm done with this PR, let's leave it open a little bit to carefully check if this is the proper thing to do.

I know the pace is a bit different during holidays, so, it might take a little while before it gets merged.

@github-actions github-actions bot added the stale label Aug 8, 2022
@drupol drupol removed the stale label Aug 8, 2022
@loophp loophp deleted a comment from github-actions bot Aug 9, 2022
@loophp loophp deleted a comment from github-actions bot Aug 9, 2022
@loophp loophp deleted a comment from github-actions bot Aug 9, 2022
@github-actions github-actions bot added the stale label Aug 14, 2022
@loophp loophp deleted a comment from github-actions bot Aug 14, 2022
@drupol drupol removed the stale label Aug 14, 2022
@github-actions github-actions bot added the stale label Aug 20, 2022
@drupol drupol removed the stale label Aug 20, 2022
@loophp loophp deleted a comment from github-actions bot Aug 20, 2022
@drupol drupol force-pushed the 256-reduction-operations-return-singlee-value branch 2 times, most recently from 0873de0 to c785876 Compare August 23, 2022 20:40
@github-actions github-actions bot added the stale label Aug 29, 2022
@loophp loophp deleted a comment from github-actions bot Aug 29, 2022
@drupol drupol removed the stale label Aug 29, 2022
@drupol drupol force-pushed the 256-reduction-operations-return-singlee-value branch 3 times, most recently from 6535897 to 6c7e485 Compare August 29, 2022 18:55
@AlexandruGG
Copy link
Collaborator

I now leave this PR to you @AlexandruGG , good work !

Thanks! I added the remaining operations and updated a couple bits of documentation that were still mentioning current.

I'll give this another fresh look tomorrow, see if I can spot anything else needed.

@drupol
Copy link
Collaborator Author

drupol commented Sep 11, 2022

Thanks! I added the remaining operations and updated a couple bits of documentation that were still mentioning current.

Indeed, nice. I was planning to do it after all the commits were done, but you did it. Thanks :)

I'll give this another fresh look tomorrow, see if I can spot anything else needed.

Ok will do that ! Cheers!

@drupol drupol force-pushed the 256-reduction-operations-return-singlee-value branch from 3a086f5 to 4013d45 Compare September 11, 2022 20:25
@AlexandruGG
Copy link
Collaborator

@drupol I went through this again and added a few more things. Please feel free to comb through the docs yourself as well and see if you can spot any bits we might have missed

Copy link
Collaborator

@AlexandruGG AlexandruGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this! 💯

@drupol
Copy link
Collaborator Author

drupol commented Sep 12, 2022

This is super great !!!

I propose to merge this, then do remaining changes if any in another branch.

We've been waiting for too long for this :)

@drupol drupol merged commit e3eaa14 into master Sep 12, 2022
@drupol drupol deleted the 256-reduction-operations-return-singlee-value branch September 12, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduction operations should return a single value
2 participants