Fix inits operation
#191
Merged
Fix inits operation
#191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandruGG
reviewed
Aug 27, 2021
| @@ -24,26 +24,26 @@ final class Inits extends AbstractOperation | |||
| /** | |||
| * @pure | |||
| * | |||
| * @return Closure(Iterator<TKey, T>): Generator<int, list<T>> | |||
| * @return Closure(Iterator<TKey, T>): Generator<int, list<array{0: TKey, 1: T}>> | |||
There was a problem hiding this comment.
can we not use Unpack to keep the previous behaviour?
There was a problem hiding this comment.
It's unfortunately not possible because each items is converted to an array of items.
There was a problem hiding this comment.
Unless using generators in place of arrays... But I don't find that very user friendly at all.
AlexandruGG
approved these changes
Aug 29, 2021
|
Job done. I updated the documentation examples. |
AlexandruGG
reviewed
Aug 31, 2021
Comment on lines
+26
to
+27
| ->inits() | ||
| ->map(static fn (array $data): array => array_column($data, 1)); |
There was a problem hiding this comment.
We could add another equivalent one:
Collection::fromIterable($input)
->inits()
->pluck('*.1');|
Since this pull request has not had any activity within the last 5 days, I have marked it as stale. |
|
@drupol please feel free to merge this once the checks have finished 😁 |
|
Thanks @AlexandruGG :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Initsoperation, it works with any type of keys now.