refactor: Update Init operation in point free style.
#186
Conversation
252517c to
d5deebd
Compare
d5deebd to
253f077
Compare
src/Operation/Init.php
Outdated
| * @param TKey $key | ||
| * @param CachingIterator<TKey, T> $iterator | ||
| */ | ||
| static fn ($value, $key, CachingIterator $iterator): bool => $iterator->getInnerIterator()->valid(); |
There was a problem hiding this comment.
for some reason Psalm thinks that getInnerIterator returns Traversable here instead of Iterator, but I cannot replicate it in the playground: https://psalm.dev/r/037fdbb040. The trace shows Iterator there.
But in this project:
INFO: Trace - src/Operation/Init.php:42:17 - $inner: Traversable (see https://psalm.dev/224)
/** @psalm-trace $inner */
$inner = $iterator->getInnerIterator();
Could it be the Psalm version? (we must be using an older one)
There was a problem hiding this comment.
Haha ! I almost made the same Psalm example to try it out on my own :)
I don't know where the issue comes from yet, I'm investigating!
There was a problem hiding this comment.
It only happens with PHP 8. Weird.
There was a problem hiding this comment.
I think I should submit this to PSalm.
There was a problem hiding this comment.
Weird. Using CachingIterator::hasNext() fixed the issue.
There was a problem hiding this comment.
I think we should open an issue on Psalm with that, sounds like a problem in PHP 8
There was a problem hiding this comment.
I did here: vimeo/psalm#6359 we'll see how it goes.
This PR:
Initin point free style.TakeWhileoperation.