Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide util class for reducer callback #131

Merged
merged 7 commits into from
Jul 9, 2021
Merged

Provide util class for reducer callback #131

merged 7 commits into from
Jul 9, 2021

Conversation

drupol
Copy link
Collaborator

@drupol drupol commented Jul 8, 2021 •
edited
Loading

This PR

  • Provide a ReducerBuilder functional and stateless class
  • Replace the use of custom reducer builder by using the new ReducerBuilder class.
  • Has tests

@drupol drupol added the enhancement New feature or request label Jul 8, 2021
@drupol drupol force-pushed the feature/provide-util-class-for-reducerCallback branch 4 times, most recently from 0f5e5c4 to 6e5ad3b Compare July 8, 2021 20:41
@drupol drupol marked this pull request as ready for review July 8, 2021 20:50
@drupol drupol marked this pull request as draft July 8, 2021 20:57
@drupol drupol force-pushed the feature/provide-util-class-for-reducerCallback branch 2 times, most recently from d623113 to 4acc5a1 Compare July 9, 2021 06:03
@drupol drupol force-pushed the feature/provide-util-class-for-reducerCallback branch from 4fb59dd to 4b51bfe Compare July 9, 2021 06:30
@drupol drupol marked this pull request as ready for review July 9, 2021 07:00
AlexandruGG
AlexandruGG approved these changes Jul 9, 2021
View reviewed changes
Copy link
Collaborator

@AlexandruGG AlexandruGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 🎉

@drupol drupol merged commit d34e218 into master Jul 9, 2021
@drupol drupol deleted the feature/provide-util-class-for-reducerCallback branch July 9, 2021 20:11
@drupol
Copy link
Collaborator Author

drupol commented Jul 9, 2021

Thanks 👍

AlexandruGG
AlexandruGG reviewed Jul 9, 2021
View reviewed changes
src/Utils/CallbacksArrayReducer.php
*
* phpcs:disable Generic.Files.LineLength.TooLong
*/
final class CallbacksArrayReducer
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could shorten the name to CallbacksReducer. Due to the plural it's quite clear we are dealing with a list of multiple callbacks

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, too late, we can tackle that in a follow-up PR...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexandruGG AlexandruGG AlexandruGG approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drupol @AlexandruGG