Update Distinct operation

[drupol]

This PR

• Update the Distinct operation
• Has an updated documentation
• Is backward compatible
• Has updated tests
• Has static tests

Fixes #110

[AlexandruGG]

here's how to fix the phpstan issue: https://phpstan.org/r/a5fbb74a-9e50-401a-b11e-05d96cc477db

[drupol]

Do you have an idea on how I could fix the annotations here @AlexandruGG ?

[AlexandruGG]

Do you have an idea on how I could fix the annotations here @AlexandruGG ?

Hey sorry I only saw this now. If everything else is done leave this to me I can have a look and try to get it ready tomorrow

[drupol]

Sure, no hurry!

[AlexandruGG]

@drupol this is sorted now, have a look at my last commit c0fca86 to see the changes done.

Maybe we can have a chat sometime so I can explain how I approach the static analysis checks to ensure that we get the types right and that we protect against incorrect usage (otherwise failures will only be detected by tests / at runtime!). It can be tricky with all the closures sometimes though 😅

[drupol]

This, is my current state of mind:

Going to read this carefully and learn! :)

[AlexandruGG]

This, is my current state of mind:

Going to read this carefully and learn! :)

😄 that was legitimately my feeling when I first found your library and looked into the code! I had never worked with so many closures and currying in PHP!

[drupol]

smile that was legitimately my feeling when I first found your library and looked into the code! I had never worked with so many closures and currying in PHP!

Haha thanks mate! Glad you like it and that you learned something! That's the spirit :)

[drupol]

Maybe we can have a chat sometime so I can explain how I approach the static analysis checks to ensure that we get the types right and that we protect against incorrect usage (otherwise failures will only be detected by tests / at runtime!). It can be tricky with all the closures sometimes though sweat_smile

Great idea, anytime !!