refactor: Minor optimizations here and there.

loophp · Apr 10, 2022 · f08d88e · f08d88e
1 parent e9c4460
commit f08d88e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 16 deletions.
diff --git a/src/Operation/Has.php b/src/Operation/Has.php
@@ -33,23 +33,17 @@ public function __invoke(): Closure
              *
              * @return Closure(iterable<TKey, T>): Generator<TKey, bool>
              */
-            static function (callable ...$callbacks): Closure {
-                /** @var Closure(iterable<TKey, T>): Generator<TKey, bool> $matchOne */
-                $matchOne = (new MatchOne())()(static fn (): bool => true)(
-                    ...array_map(
-                        static fn (callable $callback): callable =>
+            static fn (callable ...$callbacks): Closure => (new MatchOne())()(static fn (): bool => true)(
+                ...array_map(
+                    static fn (callable $callback): callable =>
                             /**
                              * @param T $value
                              * @param TKey $key
                              * @param iterable<TKey, T> $iterable
                              */
                             static fn ($value, $key, iterable $iterable): bool => $callback($value, $key, $iterable) === $value,
-                        $callbacks
-                    )
-                );
-
-                // Point free style.
-                return $matchOne;
-            };
+                    $callbacks
+                )
+            );
     }
 }
diff --git a/src/Operation/IntersectKeys.php b/src/Operation/IntersectKeys.php
@@ -34,16 +34,13 @@ public function __invoke(): Closure
              * @return Closure(iterable<TKey, T>): Generator<TKey, T>
              */
             static function (...$keys): Closure {
-                $filter = (new Filter())()(
+                return (new Filter())()(
                     /**
                      * @param T $value
                      * @param TKey $key
                      */
                     static fn ($value, $key): bool => in_array($key, $keys, true)
                 );
-
-                // Point free style.
-                return $filter;
             };
     }
 }