Update PHPDoc.

loophp · May 30, 2020 · 70fb09d · 70fb09d
1 parent 402e2de
commit 70fb09d
Show file tree

Hide file tree

Showing 6 changed files with 40 additions and 19 deletions.
diff --git a/src/Contract/Transformation.php b/src/Contract/Transformation.php
@@ -12,7 +12,7 @@ interface Transformation
     /**
      * @param iterable<mixed> $collection
      *
-     * @return bool|mixed
+     * @return iterable|mixed
      */
     public function __invoke(iterable $collection);
 }
diff --git a/src/Operation/Explode.php b/src/Operation/Explode.php
@@ -13,14 +13,14 @@
 final class Explode implements Operation
 {
     /**
-     * @var array<mixed>
+     * @var array<float|int|string>
      */
     private $explodes;
 
     /**
      * Explode constructor.
      *
-     * @param mixed ...$explodes
+     * @param float|int|string ...$explodes
      */
     public function __construct(...$explodes)
     {
@@ -33,10 +33,15 @@ public function __construct(...$explodes)
     public function __invoke(): Closure
     {
         $callbacks = array_map(
+            /**
+             * @param float|int|string $explode
+             */
             static function ($explode) {
-                return static function ($value) use ($explode): bool {
-                    return $value === $explode;
-                };
+                return
+                    /** @param mixed $value */
+                    static function ($value) use ($explode): bool {
+                        return $value === $explode;
+                    };
             },
             $this->explodes
         );

diff --git a/src/Operation/Scale.php b/src/Operation/Scale.php
@@ -49,26 +49,35 @@ public function __construct(
             $wantedUpperBound = $wantedUpperBound ?? $base;
         }
 
-        $callback = static function ($v) use ($lowerBound, $upperBound, $wantedLowerBound, $wantedUpperBound, $base): float { // phpcs:ignore
-            if (null !== $base) {
-                $mx = log($v - $lowerBound, $base) / log($upperBound - $lowerBound, $base);
+        $this->mapper = new Walk(
+            /**
+             * @param float|int $v
+             */
+            static function ($v) use ($lowerBound, $upperBound, $wantedLowerBound, $wantedUpperBound, $base): float { // phpcs:ignore
+                if (null !== $base) {
+                    $mx = log($v - $lowerBound, $base) / log($upperBound - $lowerBound, $base);
 
-                if ($mx === -INF) {
-                    $mx = 0;
+                    if ($mx === -INF) {
+                        $mx = 0;
+                    }
+                } else {
+                    $mx = ($v - $lowerBound) / ($upperBound - $lowerBound);
                 }
-            } else {
-                $mx = ($v - $lowerBound) / ($upperBound - $lowerBound);
-            }
-
-            return $wantedLowerBound + $mx * ($wantedUpperBound - $wantedLowerBound);
-        };
 
-        $this->mapper = new Walk($callback);
+                return $wantedLowerBound + $mx * ($wantedUpperBound - $wantedLowerBound);
+            }
+        );
 
         $this->filter = new Filter(
+            /**
+             * @param float|int $item
+             */
             static function ($item) use ($lowerBound): bool {
                 return $item >= $lowerBound;
             },
+            /**
+             * @param float|int $item
+             */
             static function ($item) use ($upperBound): bool {
                 return $item <= $upperBound;
             }

diff --git a/src/Transformation/First.php b/src/Transformation/First.php
@@ -42,7 +42,7 @@ public function __invoke(iterable $collection)
         $default = $this->default;
 
         if (null === $callback) {
-            $callback = static function ($value, $key): bool {
+            $callback = static function (): bool {
                 return true;
             };
         }

diff --git a/src/Transformation/Last.php b/src/Transformation/Last.php
@@ -20,6 +20,12 @@ public function __invoke(iterable $collection)
     {
         return (
         new FoldLeft(
+            /**
+             * @param mixed $carry
+             * @param mixed $item
+             *
+             * @return mixed
+             */
             static function ($carry, $item) {
                 return $item;
             }

diff --git a/src/Transformation/Transform.php b/src/Transformation/Transform.php
@@ -33,6 +33,7 @@ public function __invoke(iterable $collection)
     {
         return (
             new FoldLeft(
+                /** @return mixed */
                 static function (iterable $collection, Transformation $transformer) {
                     return $transformer($collection);
                 },