refactor: Minor SA annotations update.

We are now above 97% !
loophp · Feb 3, 2022 · 35bf8c2 · 35bf8c2
1 parent 8a3a05a
commit 35bf8c2
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 8 deletions.
diff --git a/src/Operation/Distinct.php b/src/Operation/Distinct.php
@@ -9,6 +9,7 @@
 
 namespace loophp\collection\Operation;
 
+use ArrayIterator;
 use Closure;
 use Generator;
 
@@ -42,15 +43,15 @@ public function __invoke(): Closure
                  * @return Closure(iterable<TKey, T>): Generator<TKey, T>
                  */
                 static function (callable $accessorCallback) use ($comparatorCallback): Closure {
-                    /** @var array<int, array{0: TKey, 1: T}> $stack */
-                    $stack = [];
+                    /** @var ArrayIterator<int, array{0: TKey, 1: T}> $stack */
+                    $stack = new ArrayIterator();
 
                     $filter = (new Filter())()(
                         /**
                          * @param T $value
                          * @param TKey $key
                          */
-                        static function ($value, $key) use ($comparatorCallback, $accessorCallback, &$stack): bool {
+                        static function ($value, $key) use ($comparatorCallback, $accessorCallback, $stack): bool {
                             $matchWhenNot = static fn (): bool => true;
                             $matcher =
                                 /**
@@ -64,7 +65,7 @@ static function ($value, $key) use ($comparatorCallback, $accessorCallback, &$st
                                 return false;
                             }
 
-                            $stack[] = [$key, $value];
+                            $stack->append([$key, $value]);
 
                             return true;
                         }

diff --git a/src/Operation/Dump.php b/src/Operation/Dump.php
@@ -42,6 +42,8 @@ public function __invoke(): Closure
                      */
                     static fn (?Closure $callback = null): Closure =>
                         /**
+                         * @param iterable<TKey, T> $iterable
+                         *
                          * @return Generator<TKey, T>
                          */
                         static function (iterable $iterable) use ($name, $size, $callback): Generator {

diff --git a/src/Operation/Duplicate.php b/src/Operation/Duplicate.php
@@ -9,6 +9,7 @@
 
 namespace loophp\collection\Operation;
 
+use ArrayIterator;
 use Closure;
 use Generator;
 
@@ -42,15 +43,15 @@ public function __invoke(): Closure
                  * @return Closure(iterable<TKey, T>): Generator<TKey, T>
                  */
                 static function (callable $accessorCallback) use ($comparatorCallback): Closure {
-                    /** @var array<int, array{0: TKey, 1: T}> $stack */
-                    $stack = [];
+                    /** @var ArrayIterator<int, array{0: TKey, 1: T}> $stack */
+                    $stack = new ArrayIterator();
 
                     $filter = (new Filter())()(
                         /**
                          * @param T $value
                          * @param TKey $key
                          */
-                        static function ($value, $key) use ($comparatorCallback, $accessorCallback, &$stack): bool {
+                        static function ($value, $key) use ($comparatorCallback, $accessorCallback, $stack): bool {
                             $matchWhenNot = static fn (): bool => true;
                             $matcher =
                                 /**
@@ -64,7 +65,7 @@ static function ($value, $key) use ($comparatorCallback, $accessorCallback, &$st
                                 return true;
                             }
 
-                            $stack[] = [$key, $value];
+                            $stack->append([$key, $value]);
 
                             return false;
                         }