Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markdown linting script #95

Merged
merged 1 commit into from
Oct 7, 2016
Merged

Add markdown linting script #95

merged 1 commit into from
Oct 7, 2016

Conversation

Sequoia
Copy link
Contributor

@Sequoia Sequoia commented Oct 7, 2016

Related to #49 (tho it does not necessarily close it). See #49 for extensive discussion of the problem & solution contained herein.

This PR does not tie the linting task into the fetch-readmes task as almost all readmes would fail currently. Once all readmes are cleaned up & commit hooks are set up on targeted repos, we can add the check here as well if needed.

@slnode
Copy link
Contributor

slnode commented Oct 7, 2016

Can one of the admins verify this patch?

@crandmck crandmck merged commit e0c8a6e into gh-pages Oct 7, 2016
@crandmck crandmck removed the #review label Oct 7, 2016
@crandmck
Copy link
Contributor

crandmck commented Oct 7, 2016

I just noticed that this uses https://github.com/Sequoia/markdownlint-cli. It's fine for now, but in the long run I think we'd prefer to use https://www.npmjs.com/package/markdownlint-cli, or if we can't upstream your changes, then fork it into the strongloop org.

@Sequoia
Copy link
Contributor Author

Sequoia commented Oct 8, 2016

I had to fork that repo because there was a sort of major bug affecting long output. I submitted a PR but I didn't want to wait to use it so I pointed to my version. Here's the PR igorshubovych/markdownlint-cli#11 as soon as it lands we can point this to upstream.

-Sequoia

On Oct 7, 2016, at 7:53 PM, Rand McKinney notifications@github.com wrote:

I just noticed that this uses https://github.com/Sequoia/markdownlint-cli. It's fine for now, but in the long run I think we'd prefer to use https://www.npmjs.com/package/markdownlint-cli, or if we can't upstream your changes, then fork it into the strongloop org.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@crandmck crandmck deleted the markdown-lint branch October 24, 2016 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants