-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use NPM workspaces #9562
Conversation
b34befd
to
80d2bc7
Compare
4e59738
to
f9c676b
Compare
@shubhamp-sf Do you know what might be going on here?
|
@frbuceta I see the code changes removed package-lock json and lerna bootstrap step. I tried it locally but it didn't install packages for me. So sequelize and typeorm are looking for that package and not finding it. |
Btw why are we moving onto NPM workspaces here? Is there any discussion thread I can go through? |
f0e9fef
to
f9c676b
Compare
Also, the project installs the dependencies super fast and that makes the tests in github run much faster. |
Oh okay, then IMO the only culprit can be |
Yes, that's right. The strange thing is that it only fails in GitHub Actions. |
Signed-off-by: Francisco Buceta <frbuceta@gmail.com>
50dea93
to
8a4aea6
Compare
Signed-off-by: Francisco Buceta <frbuceta@gmail.com>
7856d55
to
3c7f36e
Compare
Signed-off-by: Francisco Buceta <frbuceta@gmail.com>
e0e5326
to
7989004
Compare
7989004
to
dc03796
Compare
@raymondfeng Can you help me understand what's going on with webpack, with the web compilation? |
c557915
to
952f360
Compare
See #9602 Signed-off-by: Francisco Buceta <frbuceta@gmail.com>
952f360
to
d05b64a
Compare
No description provided.