-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: lb3 migration tests for models customized with db metadata #4710
Conversation
659f9f7
to
2123ed1
Compare
4086110
to
16f22f3
Compare
@deepakrkris, there's error in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 For fixing the lint error.
Otherwise LGTM 👍
16f22f3
to
4d7dee0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
type: `'string'`, | ||
tsType: 'string', | ||
length: 25, | ||
postgresql: `{columnName: 'name', dataType: 'character varying', dataLength: 25, dataPrecision: null, dataScale: null, nullable: 'YES'}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deepakrkris I'm just wondering why a string and not an object passed here. Why is this not like this?:
{
type: `'string'`,
tsType: 'string',
length: 25,
postgresql: {
columnName: 'name',
dataType: 'character varying',
dataLength: 25,
dataPrecision: null,
dataScale: null,
nullable: 'YES'
},
},
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@derdeka thanks for the review. The unit test is for the function importLb3ModelDefinition
it returns json values as strings. But the template generator takes care of converting into json objects.
satisfies: #3810
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm test
passes on your machinepackages/cli
were updatedexamples/*
were updated👉 Check out how to submit a PR 👈