Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(rest-explorer): improve test names #2884

Merged
merged 1 commit into from
May 14, 2019
Merged

refactor(rest-explorer): improve test names #2884

merged 1 commit into from
May 14, 2019

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented May 14, 2019 •
edited
Loading

As pointed out by @emonddr, see #2856.

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@bajtos
refactor(rest-explorer): improve test names
0cccae6 
Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
@bajtos bajtos added this to the May 2019 milestone milestone May 14, 2019
@bajtos bajtos requested a review from emonddr May 14, 2019 07:12
@bajtos bajtos requested a review from raymondfeng as a code owner May 14, 2019 07:12
@bajtos bajtos self-assigned this May 14, 2019
emonddr
emonddr approved these changes May 14, 2019
View reviewed changes
Copy link
Contributor

@emonddr emonddr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you :)

@bajtos bajtos merged commit a956d86 into master May 14, 2019
@bajtos bajtos deleted the refactor/test-names branch May 14, 2019 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabdelgadir nabdelgadir nabdelgadir approved these changes

@emonddr emonddr emonddr approved these changes

@raymondfeng raymondfeng Awaiting requested review from raymondfeng

Assignees

@bajtos bajtos

Labels
API Explorer refactor
Projects
None yet
Milestone
May 2019 milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bajtos @emonddr @nabdelgadir