fix(rest): only return matched trie nodes with values #2375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
bajtos
approved these changes
Feb 12, 2019
| @@ -214,6 +214,44 @@ function runTestsWithRouter(router: RestRouter) { | |||
| expect(route.pathParams).to.containEql({userId: '1', format: 'json'}); | |||
| }); | |||
|
|
|||
| it('finds "GET /orders/ and GET /orders/{id}" endpoints', () => { | |||
There was a problem hiding this comment.
Suggested change
| it('finds "GET /orders/ and GET /orders/{id}" endpoints', () => { | |
| it('finds "GET /orders and GET /orders/{id}" endpoints', () => { |
The test names should match the code.
| async findOrders(): Promise<object[]> { | ||
| return []; | ||
| } | ||
| // A path overlaps with `/order/{id}`. Please note a different var name |
There was a problem hiding this comment.
Suggested change
| // A path overlaps with `/order/{id}`. Please note a different var name | |
| // A path overlaps with `/orders/{id}`. Please note a different var name |
There was a problem hiding this comment.
nitpick: A path overlaps -> A path that overlaps
b-admike
approved these changes
Feb 12, 2019
| async findOrders(): Promise<object[]> { | ||
| return []; | ||
| } | ||
| // A path overlaps with `/order/{id}`. Please note a different var name |
There was a problem hiding this comment.
nitpick: A path overlaps -> A path that overlaps
7284e4c to
6e2a40b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2188
This is a spin-off from #2355.
Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated