-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: drop multiple dist targets, always use es2017 #1803
Conversation
503069e
to
ba4bb84
Compare
Grr. Apparently |
ba4bb84
to
6e6de52
Compare
5cfb7e9
to
1f36d7b
Compare
1f36d7b
to
cffa630
Compare
Uff, we have so many places affected by the design decision to support multiple dist targets! I hope that I found them all, unfortunately it makes the change-set huge. The pull request is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thank you for the effort!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Excellent @bajtos !
Based on the work in #1636, it's clear that we cannot continue building for multiple ES targets (ES2017 for Node.js 8.x and ES2018 for Node.js 10.x) if we want to use TypeScript Project References. (And we do want to!)
This pull request is removing multi-dist build and switching all packages (including project templates) to always build for ES2017 (Node.js 8.x) only.
dist10
is removed completelydist8
is moved todist
build:dist8
,build:dist10
andbuild:dist-all
scripts are removed in favor ofbuild:dist
lb-mocha
'sDIST
template, usedist
instead@loopback/dist-util
, load./dist
directly. Keep using@loopback/dist-util
inside CLI - we need the version checkcompile-package
to correctly treat--outDir
path as relative to CWD