chore(rest-explorer): remove redirect from /explorer/ to /explorer

loopbackio · Feb 8, 2019 · d1f4243 · d1f4243
1 parent 56126a0
commit d1f4243
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 11 deletions.
diff --git a/packages/rest-explorer/src/__tests__/acceptance/rest-explorer.acceptance.ts b/packages/rest-explorer/src/__tests__/acceptance/rest-explorer.acceptance.ts
@@ -36,11 +36,12 @@ describe('API Explorer (acceptance)', () => {
         .expect(/<title>LoopBack API Explorer/);
     });
 
-    it('redirects from "/explorer" to "/explorer/"', async () => {
+    it('exposes API Explorer at "/explorer"', async () => {
       await request
         .get('/explorer')
-        .expect(301)
-        .expect('location', '/explorer/');
+        .expect(200)
+        .expect('content-type', /html/)
+        .expect(/<title>LoopBack API Explorer/);
     });
 
     it('configures swagger-ui with OpenAPI spec url "/openapi.json', async () => {
@@ -92,8 +93,7 @@ describe('API Explorer (acceptance)', () => {
 
       await request
         .get('/openapi/ui')
-        .expect(301)
-        .expect('Location', '/openapi/ui/');
+        .expect(200, /<title>LoopBack API Explorer/);
 
       await request.get('/explorer').expect(404);
     });

diff --git a/packages/rest-explorer/src/rest-explorer.component.ts b/packages/rest-explorer/src/rest-explorer.component.ts
@@ -24,8 +24,7 @@ export class RestExplorerComponent implements Component {
   ) {
     const explorerPath = config.path || '/explorer';
 
-    this.registerControllerRoute('get', explorerPath, 'indexRedirect');
-    this.registerControllerRoute('get', explorerPath + '/', 'index');
+    this.registerControllerRoute('get', explorerPath, 'index');
 
     application.static(explorerPath, swaggerUI.getAbsoluteFSPath());
 

diff --git a/packages/rest-explorer/src/rest-explorer.controller.ts b/packages/rest-explorer/src/rest-explorer.controller.ts
@@ -32,10 +32,6 @@ export class ExplorerController {
     this.openApiSpecUrl = this.getOpenApiSpecUrl(restConfig);
   }
 
-  indexRedirect() {
-    this.response.redirect(301, this.request.url + '/');
-  }
-
   index() {
     const data = {
       openApiSpecUrl: this.openApiSpecUrl,