fixup! rework tests and fix express composition

Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
loopbackio · May 13, 2019 · 842415b · 842415b
1 parent 960518e
commit 842415b
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 10 deletions.
diff --git a/packages/rest-explorer/src/__tests__/acceptance/rest-explorer.acceptance.ts b/packages/rest-explorer/src/__tests__/acceptance/rest-explorer.acceptance.ts
@@ -125,10 +125,12 @@ describe('API Explorer (acceptance)', () => {
 
     it('uses correct URLs', async () => {
       // static assets (including swagger-ui) honor basePath
-      const response = await request.get('/api/explorer/').expect(200);
-      const body = response.body;
-      // OpenAPI endpoints DO NOT honor basePath
-      expect(body).to.match(/^\s*url: '\/openapi.json',\s*$/m);
+      await request
+        .get('/api/explorer/')
+        .expect(200)
+        .expect('content-type', /html/)
+        // OpenAPI endpoints DO NOT honor basePath
+        .expect(/url\: '\/openapi\.json'\,/);
     });
   });
 

diff --git a/packages/rest-explorer/src/__tests__/acceptance/rest-explorer.express.acceptance.ts b/packages/rest-explorer/src/__tests__/acceptance/rest-explorer.express.acceptance.ts
@@ -7,7 +7,6 @@ import {RestApplication, RestServer, RestServerConfig} from '@loopback/rest';
 import {
   Client,
   createClientForHandler,
-  expect,
   givenHttpServerConfig,
 } from '@loopback/testlab';
 import * as express from 'express';
@@ -38,10 +37,13 @@ describe('REST Explorer mounted as an express router', () => {
 
   it('honors basePath config', async () => {
     server.basePath('/v1');
-    // static assets (including swagger-ui) honor basePath
-    const response = await client.get('/api/v1/explorer/').expect(200);
-    // OpenAPI endpoints DO NOT honor basePath
-    expect(response.body).to.match(/^\s*url: '\/api\/openapi.json',\s*$/m);
+    await client
+      // static assets (including swagger-ui) honor basePath
+      .get('/api/v1/explorer/')
+      .expect(200)
+      .expect('content-type', /html/)
+      // OpenAPI endpoints DO NOT honor basePath
+      .expect(/url\: '\/api\/openapi\.json'\,/);
   });
 
   async function givenLoopBackApp(

diff --git a/packages/rest-explorer/src/rest-explorer.controller.ts b/packages/rest-explorer/src/rest-explorer.controller.ts
@@ -53,7 +53,7 @@ export class ExplorerController {
     }
 
     if (rootPath && rootPath !== '/') {
-      openApiSpecUrl = this.request.baseUrl + openApiSpecUrl;
+      openApiSpecUrl = rootPath + openApiSpecUrl;
     }
     const data = {
       openApiSpecUrl,