Align Carb and Bolus Guardrail Behavior #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StatusLGTM TestThe setting for max carbs (protein/fat) was set to 30 g. Test beforeConfirmed that a carb entry of 45 was automatically modified to 4 g and uploaded. Test with PRConfirmed that a carb entry of 45 caused an out-of-bound alert whether hitting the end entry or the send meal button. Confirmed that when Protein/Fat was added to meal options, they also alerted properly. |
marionbarker
approved these changes
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the last valid value was used for the meal entry. Now the invalid value is cleared and the error message is displayed correctly.