Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IAGE Support and Migrate InfoDisplaySettings to SwiftUI #323

Merged
merged 6 commits into from
Aug 7, 2024
Merged

Conversation

bjorkert
Copy link
Contributor

@bjorkert bjorkert commented Aug 6, 2024

Summary

This pull request adds support for the IAGE event type and enhances the Information Display Settings with SwiftUI.

Key Features

  1. IAGE Event Integration

    • Implemented support for tracking and displaying the IAGE (Insulin Cartridge Change) event.
  2. Information Display Settings Enhancements

    • Migrated the settings page from UIKit/Eureka to SwiftUI
    • Fixes a bug in the current dev branch where toggling an item's visibility would visually reset the sort order, even though the persisted sort order was correct.

@marionbarker
Copy link
Collaborator

Summary

A few minor comments.

Code Review

Looks good

Test

Built onto SE
Reading data from OpenAPS (Trio) Test Site

  • add treatment for insulin cartridge change and sensor start
  • both are displayed on LF
  • moved the rows around and info table rearranged as expected

Switch to Loop Site

  • Updated is not showing a value - should that not be last Loop upload?

Suggestions

  • Update in table shows
    • hh:mm:ss am/pm for 12 hour time phone (pretty crowded)
    • hh:mm:ss for 24 hour time display
    • I think hh:mm should be sufficient

Copy link
Collaborator

@marionbarker marionbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noted a few changes you may want to address.
Otherwise, I approve the code.

@bjorkert
Copy link
Contributor Author

bjorkert commented Aug 7, 2024

I can address Updated in a separate PR, since it was introduced in this one.

@bjorkert bjorkert merged commit c5c3980 into dev Aug 7, 2024
@bjorkert bjorkert deleted the iage branch August 7, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants