-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
72 frame additions and revisions #147
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* changes to accompany those in https://github.com/lookit/lookit-api/tree/feature/62-pattern-preview-after-participate to allow saving data and using child info during preview * formatting fixes including so that exp-video-config-quality 'showRecordMenu' option works with updated Pipe recorder * make sure future frames of type exp-video-config-quality aren't affected * gah still fixing for multiple frames * finally actually tested fix for removing offending css * fix for using exp-frame-select w/o any conditions * Persist selection of cam/mic across sessions (dealing with Firefox issue similar to https://bugzilla.mozilla.org/show_bug.cgi?id=1142123), and allow selection of cam/mic on the setup page. * style fixes * simplify docs by removing pieces that are only used by developers but aren't really useful to them anyway * add exp-lookit-webcam-display frame for simple display of webcam * bump default font size up to encourage designing studies with less text * add example videos to frame documentation and update docs * style fixes * fix a few examples in docs * merge develop * update docs * set window title to experiment name instead of Lookit upon loading study * condense event data stored by only saving video ID and pipe ID in one event * remove useless fetch calls from expandAssets, document issues with this approach for later * add exp-lookit-change-detection frame for alternation/change-detection paradigms * update docs * add combined preview frame (instead of separate preview-explanation and preview frames) * provide information about data stored and sent to lookit for each frame individually, in separate tab of frame docs; remove deprecated frames from display; make properties researchers don't set private * stimuli preview frame docs * initial progress on image-audio and single-image frames * simplify docs by removing pieces that are only used by developers but aren't really useful to them anyway * add exp-lookit-webcam-display frame for simple display of webcam * bump default font size up to encourage designing studies with less text * fix a few examples in docs * merge develop * update docs * set window title to experiment name instead of Lookit upon loading study * condense event data stored by only saving video ID and pipe ID in one event * remove useless fetch calls from expandAssets, document issues with this approach for later * add exp-lookit-change-detection frame for alternation/change-detection paradigms * update docs * add combined preview frame (instead of separate preview-explanation and preview frames) * provide information about data stored and sent to lookit for each frame individually, in separate tab of frame docs; remove deprecated frames from display; make properties researchers don't set private * stimuli preview frame docs * initial progress on image-audio and single-image frames * add additional_segments option to exp-lookit-video-consent and update docs accordingly (#137) * add documentation of stimuli-preview frame
…asier to see and deal with bigger default font size
Bumps [jquery](https://github.com/jquery/jquery) from 3.3.1 to 3.5.0. - [Release notes](https://github.com/jquery/jquery/releases) - [Commits](jquery/jquery@3.3.1...3.5.0) Signed-off-by: dependabot[bot] <support@github.com>
…o to exp-lookit-video-consent, addresses #141. Add check of webcam permissions to exp-video-config.
…unctions rather than only actions in base frame; finish exp-lookit-single-image-audio
…ot, and previous releases under releases/<release>/, with a dropdown menu)
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.13. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.11...4.17.13) Signed-off-by: dependabot[bot] <support@github.com>
…ub.com/lookit/ember-lookit-frameplayer into 72-frame-additions-and-revisions
…resulting vulnerability in hoek dependency
…dependencies including use of lodash 3.x
…sion of lodash.template, and finish bumping handlebars version
… long - union-value, cache-base, base, snapdragon, (nanomatch, micromatch, extglob, expand-brackets, braces, ...) so removed locked version choices along chain & reinstalled.
…s rather than strings
This reverts commit d16f815.
…mber-lookit-frameplayer and push changes to lookit-frameplayer-docs
…ecording if session recording is active
…about starting/stopping video as frame is ending)
… as they'll need to be set up differently if eventually implementing
…player into 72-frame-additions-and-revisions * 'master' of https://github.com/lookit/ember-lookit-frameplayer: Set theme jekyll-theme-cayman # Conflicts: # docs
…ted to be when running non-locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a variety of new general-purpose frames, per #72