Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix preemptive authentication without explicit port (#285) #348

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Fix preemptive authentication without explicit port (#285) #348

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/com/github/sardine/impl/SardineImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,8 +371,8 @@ public void enablePreemptiveAuthentication(String hostname, int httpPort, int ht
// Generate Basic preemptive scheme object and stick it to the local execution context
BasicScheme basicAuth = new BasicScheme(credentialsCharset);
// Configure HttpClient to authenticate preemptively by prepopulating the authentication data cache.
cache.put(new HttpHost(hostname, httpPort, "http"), basicAuth);
cache.put(new HttpHost(hostname, httpsPort, "https"), basicAuth);
cache.put(new HttpHost(hostname, httpPort == -1 ? 80 : httpPort, "http"), basicAuth);
cache.put(new HttpHost(hostname, httpsPort == -1 ? 443 : httpsPort, "https"), basicAuth);
}

@Override
Expand Down