fix(log): reduce auto balancing logging noise for detached volumes

[dihmandrake]

Which issue(s) this PR fixes:

Issue longhorn/longhorn#10302

What this PR does / why we need it:

Reduce auto balancing logging noise for detached volumes. This might also be confusing and prompt people to investigate these messages are errors (they are warning) - at least I did

Special notes for your reviewer:

Additional documentation or context

[coderabbitai]

Walkthrough

This pull request updates the logging behavior in the volume controller during the auto-balance process for volume replicas. An additional condition checks if the volume state is not detached before logging a warning when auto-balancing fails. This change prevents excessive logging for detached volumes and provides detailed messages that include both the robustness and state of the volume without modifying the core functionality.

Changes

Files	Change Summary
controller/volume_controller.go	Modified logging in the auto-balance process to include a condition that checks the volume state, preventing log entries for detached volumes.

Sequence Diagram(s)

sequenceDiagram
    participant VC as VolumeController
    participant V as VolumeState
    participant L as Logger

    VC->>V: Retrieve volume state during auto-balance
    alt Volume state is active
        VC->>L: Log warning including robustness and state details
    else Volume state is detached
        VC->>L: Skip logging warning
    end

Loading

Possibly related PRs

• fix: change misleading error message to warning level #3316: Modifies logging behavior in the same file to reduce misleading log entries related to volume states.

Suggested reviewers

• innobead

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 51b2097 and d6c9149.

📒 Files selected for processing (1)

• controller/volume_controller.go (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• controller/volume_controller.go

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Summary

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[derekbit]

cc @c3y1huang

[derekbit]

@mergify backport v1.8.x

[mergify]

backport v1.8.x

✅ Backports have been created

• #3565 fix(log): reduce auto balancing logging noise for detached volumes (backport #3558) has been created for branch v1.8.x