fix(system-backup): skip backup if it is a DR volume

[mantissahz]

Which issue(s) this PR fixes:

Issue # longhorn/longhorn#6027, longhorn/longhorn#9330, longhorn/longhorn#10239

What this PR does / why we need it:

Special notes for your reviewer:

Additional documentation or context

[coderabbitai]

Walkthrough

The pull request modifies the backupVolumesIfNotPresent method in the SystemBackupController class. The key change is the addition of a check to determine if a volume backup is up-to-date before creating a new backup. If a volume's backup is current relative to the system backup being processed, the method skips creating a new backup. This optimization prevents unnecessary backup operations for volumes with recent backups, improving the efficiency of the backup process.

Changes

File	Change Summary
controller/system_backup_controller.go	Added logic to check volume backup currency before creating a new backup

Possibly related PRs

• fix(system-backup): handle snapshot of last backup removed #3478: Enhances isVolumeBackupUpToDate method in the same SystemBackupController class, focusing on error handling for backup snapshots

Suggested reviewers

• innobead
• PhanLe1010
• derekbit

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 354b11d and 50edde2.

📒 Files selected for processing (1)

• controller/system_backup_controller.go (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Build binaries
• GitHub Check: Summary

🔇 Additional comments (1)

controller/system_backup_controller.go (1)

802-808: LGTM! The implementation correctly skips backup for DR volumes.

The code successfully implements the PR objective by skipping backup for DR (standby) volumes, which is the correct behavior since these volumes are restored from their source volume's backup. The log message provides clear visibility into skipped volumes.

Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[derekbit]

@mergify backport v1.8.x

[mergify]

backport v1.8.x

✅ Backports have been created

• #3488 fix(system-backup): skip backup if it is a DR volume (backport #3487) has been created for branch v1.8.x