Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(system-backup): handle snapshot of last backup removed (backport #3478) #3479

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jan 16, 2025

Which issue(s) this PR fixes:

Issue # longhorn/longhorn#10215

What this PR does / why we need it:

The snapshot of the last backup of the volume might be removed. Therefore, volume backup will not be up to date and needs to create a new backup.

Special notes for your reviewer:

Additional documentation or context

https://ci.longhorn.io/job/private/job/longhorn-tests-regression/8300/ - passed


This is an automatic backport of pull request #3478 done by Mergify.

Copy link

coderabbitai bot commented Jan 16, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mantissahz mantissahz requested a review from derekbit January 16, 2025 01:51
@mantissahz mantissahz self-assigned this Jan 16, 2025
The snapshot of the last backup of the volume might be removed.
Therefore, volume backup will be not up-to-date and it needs to
create a new backup.

ref: longhorn/longhorn 10215

Signed-off-by: James Lu <james.lu@suse.com>
(cherry picked from commit 36f3ed2)
@derekbit derekbit force-pushed the mergify/bp/v1.8.x/pr-3478 branch from 35bb325 to 8f7f38c Compare January 16, 2025 02:37
@derekbit derekbit merged commit fb23f3a into v1.8.x Jan 16, 2025
9 of 11 checks passed
@derekbit derekbit deleted the mergify/bp/v1.8.x/pr-3478 branch January 16, 2025 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants