Ensure delete actions remove inbound edges #1820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only thing I'm not 100% sure about is soft deletes, but I believe those get their delete actions converted to update actions, so it won't have any effect here.
lolopinto
approved these changes
Aug 10, 2024
| @@ -14,7 +14,7 @@ | |||
| {{$tsFieldName := $field.TsBuilderFieldName -}} | |||
|
|
|||
| {{/* we magically expect a local variable input to be defined when this is used */ -}} | |||
| if (input.{{$tsFieldName}} !== undefined) { | |||
| if (input.{{$tsFieldName}} !== undefined || this.operation === WriteOperation.Delete) { | |||
There was a problem hiding this comment.
this makes sense. my guess is it expects only the remove parts to apply for deletes?
There was a problem hiding this comment.
In looking at this file now I might have to add this check in other places too. Let me do some checking before we merge this.
There was a problem hiding this comment.
Ok, finally got back around to this and double checked everything. This should be good to merge. 👍
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only thing I'm not 100% sure about is soft deletes, but I believe those get their delete actions converted to update actions, so it won't have any effect here.
Fixes #1819