New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

combine call into auto_schema where no changes #453

Closed

lolopinto opened this issue Sep 1, 2021 · 0 comments

Owner

lolopinto commented Sep 1, 2021

or create a server that's listening in the background and kill later?

lolopinto added a commit that referenced this issue


          when there's no db changes, no need to call into auto_schema a second…

cdd8ccd

… time

both paths are running the same code
https://github.com/lolopinto/ent/blob/main/python/auto_schema/auto_schema/runner.py#L185
https://github.com/lolopinto/ent/blob/main/python/auto_schema/auto_schema/runner.py#L258

so no reason to call this twice.

we just keep a flag in golang that we check and avoid the overhead a second time

way simpler than options presented at #453

lolopinto mentioned this issue

when there's no db changes, no need to call into auto_schema a second time #461

Merged

lolopinto closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment