Fixes #77:Hidden top on upscrolling #142
Conversation
|
Please check failing tests and provide a test site on your GitHub pages. |
|
Test site link : https://sushmakukkadapu.github.io/ @mariobehling |
|
Thank you. The move up of the top bar is delayed. I am not sure why. Please implement it without any delay. |
|
Yeah sure, @mariobehling will set the delay thing, but before I create a new PR, does this existing PR needs to be merged or cleared? (in order to avoid clash) |
|
You need to update your branch. |
There was a problem hiding this comment.
@KukkadapuSushma Please remove the trailing white spaces so that travis doesn't show failures.
You can remove the console statements from the function you have added in loklak.js as I guess those statements were used for debugging purpose.
One more thing, On scrolling up, the search bar (top bar) gets hidden (after some delay as Mario has already mentioned) but when I scroll back down and the top bar reappears, the gray bar and the green bar beside it are not vertically aligned. Could you please fix it.Also make sure that the entire thing is also working in mobile view, as of now in mobile view when you scroll up the top bar is not entirely getting hidden.
|
@djmgit @jig08 @mariobehling |
|
@mariobehling Ok sure I will see through it again. |
|
https://sushmakukkadapu.github.io/ |
|
Please compare to https://play.google.com and check how you can speed up the feature. Thanks |
|
Ok, let's speed this up. I am merging this and we can iterate from here. Thank you. |
|
Thanks for the merge, will speed up, I have understood after looking thoroughly at https://play.google.com . |
Here are few screenshots to visualize the change 👍
Link for demo : https://sushmakukkadapu.github.io/
@daminisatya @jig08 @mariobehling
.
.