Change default settings to avoid memory-overflow and dropped logs

logtail · Jun 26, 2024 · 451ea78 · 451ea78
1 parent d8e9ba3
commit 451ea78
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 7 deletions.
diff --git a/src/Monolog/LogtailHandler.php b/src/Monolog/LogtailHandler.php
@@ -19,6 +19,9 @@
  */
 class LogtailHandler extends BufferHandler
 {
+    const DEFAULT_BUBBLE = true;
+    const DEFAULT_BUFFER_LIMIT = 1000;
+    const DEFAULT_FLUSH_ON_OVERFLOW = true;
     const DEFAULT_ALWAYS_FLUSH_AFTER_MILLISECONDS = 1000;
 
     /**
@@ -45,10 +48,10 @@ class LogtailHandler extends BufferHandler
     public function __construct(
         $sourceToken,
         $level = Logger::DEBUG,
-        $bubble = true,
+        $bubble = self::DEFAULT_BUBBLE,
         $endpoint = LogtailClient::URL,
-        $bufferLimit = 0,
-        $flushOnOverflow = false,
+        $bufferLimit = self::DEFAULT_BUFFER_LIMIT,
+        $flushOnOverflow = self::DEFAULT_FLUSH_ON_OVERFLOW,
         $connectionTimeoutMs = LogtailClient::DEFAULT_CONNECTION_TIMEOUT_MILLISECONDS,
         $timeoutMs = LogtailClient::DEFAULT_TIMEOUT_MILLISECONDS,
         $alwaysFlushAfterMs = self::DEFAULT_ALWAYS_FLUSH_AFTER_MILLISECONDS

diff --git a/src/Monolog/LogtailHandlerBuilder.php b/src/Monolog/LogtailHandlerBuilder.php
@@ -17,10 +17,10 @@ final class LogtailHandlerBuilder
 {
     private $sourceToken;
     private $level = Logger::DEBUG;
-    private $bubble = true;
+    private $bubble = LogtailHandler::DEFAULT_BUBBLE;
     private $endpoint = LogtailClient::URL;
-    private $bufferLimit = 0;
-    private $flushOnOverflow = false;
+    private $bufferLimit = LogtailHandler::DEFAULT_BUFFER_LIMIT;
+    private $flushOnOverflow = LogtailHandler::DEFAULT_FLUSH_ON_OVERFLOW;
     private $connectionTimeoutMs = LogtailClient::DEFAULT_CONNECTION_TIMEOUT_MILLISECONDS;
     private $timeoutMs = LogtailClient::DEFAULT_TIMEOUT_MILLISECONDS;
     private $alwaysFlushAfterMs = LogtailHandler::DEFAULT_ALWAYS_FLUSH_AFTER_MILLISECONDS;

diff --git a/src/Monolog/SynchronousLogtailHandler.php b/src/Monolog/SynchronousLogtailHandler.php
@@ -33,7 +33,7 @@ class SynchronousLogtailHandler extends \Monolog\Handler\AbstractProcessingHandl
     public function __construct(
         $sourceToken,
         $level = \Monolog\Logger::DEBUG,
-        $bubble = true,
+        $bubble = LogtailHandler::DEFAULT_BUBBLE,
         $endpoint = LogtailClient::URL,
         $connectionTimeoutMs = LogtailClient::DEFAULT_CONNECTION_TIMEOUT_MILLISECONDS,
         $timeoutMs = LogtailClient::DEFAULT_TIMEOUT_MILLISECONDS