Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two bugs in "#open_jdbc_connection" when rescuing a DatabaseConnectionError #220

Closed
guyboertje opened this issue Jun 20, 2017 · 4 comments
Closed

Two bugs in "#open_jdbc_connection" when rescuing a DatabaseConnectionError #220

guyboertje opened this issue Jun 20, 2017 · 4 comments
Assignees
@guyboertje
Labels
bug

Comments

@guyboertje
Copy link
Contributor

In the open_jdbc_connection method.

  1. close_jdbc_connection is called on @database - it has no such method.
  2. The logged warning does not capture valuable JDBC Driver messages/trace that may be in the DatabaseConnectionError instance.
@guyboertje guyboertje added the bug label Jun 20, 2017
@guyboertje guyboertje self-assigned this Jun 20, 2017
@avihaleva
Copy link

Does reconnect works in any scenario ? Looks like when their is any error on the connection, the connection will never recover. Is there any workaround for this issue ? Can I cause Logstash to terminate on such error ?

@franklauterwald
Copy link
Contributor

@avihaleva I just created pull request #231 which solves the reconnection issue for us. Can you try if it helps you? It is supposed to fix reconnecting

@guyboertje guyboertje mentioned this issue Aug 18, 2017
Merged
franklauterwald pushed a commit to franklauterwald/logstash-input-jdbc that referenced this issue Aug 20, 2017
Issue logstash-plugins#220: Log caught exception
cdf20b2
franklauterwald pushed a commit to franklauterwald/logstash-input-jdbc that referenced this issue Aug 20, 2017
@franklauterwald
Issue logstash-plugins#220: Log caught exception
189145b
franklauterwald added a commit to franklauterwald/logstash-input-jdbc that referenced this issue Aug 20, 2017
@franklauterwald
Issue logstash-plugins#220: Log caught exception
cafd8f3
guyboertje pushed a commit that referenced this issue Aug 21, 2017
@franklauterwald
Issue #220: Log caught exception
5c9160b
@guyboertje
Copy link
Contributor Author

Closed with #231

@guyboertje
Copy link
Contributor Author

@avihaleva @franklauterwald
New version of plugin published, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guyboertje guyboertje

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@guyboertje @franklauterwald @avihaleva